[wip] Reduce image pull/save for PR CI #6365
Draft
+303
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to pull and save images when building tags, if building an untagged dev release, just inspect to make sure the images all exist Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
slim-docker-save
branch
2 times, most recently
from
09f7127 to
f10de29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6365 +/- ##
=======================================
Coverage 25.23% 25.23%
=======================================
Files 33 33
Lines 2829 2829
=======================================
Hits 714 714
Misses 2068 2068
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
force-pushed
the
slim-docker-save
branch
6 times, most recently
from
7f5f6bf to
4b33a5d
Compare
brandond
force-pushed
the
slim-docker-save
branch
5 times, most recently
from
cd7064b to
df65769
Compare
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
slim-docker-save
branch
from
df65769 to
b990268
Compare
brandond
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace drone with GHA and add support for buildx dapper#121
Proposed Changes
We only need to pull and save images when building tags, if building an untagged dev release, just inspect to make sure the images all exist.
This should shorten PR builds, as well as reducing the amount of throttling on docker hub pulls.
The default builder's mirrors can only be configured by modifying docker's daemon.json and restarting docker on the runner itself. If we use a containerized builder we can configure it in the workflow.
Types of Changes
ci
Verification
See CI logs - note that the images are still checked, but no longer pulled and packaged, when not building a release.
Testing
Linked Issues
User-Facing Change
Further Comments